SmartTokenLabs / TokenScript

TokenScript schema, specs and paper
http://tokenscript.org
MIT License
241 stars 71 forks source link

Schema/2020/03 #332

Closed SmartLayer closed 4 years ago

SmartLayer commented 4 years ago

Implemented: https://community.tokenscript.org/t/weekly-design-meeting-21/329

Unimplemented: the use of RDN to identify token and the use of disctinct attributes (forming RDN) instead of using <origin> for token. - We talked about that in the weekly meeting but that change is significant and we push it to the next version of the schema.

hboon commented 4 years ago

@colourful-land changing view-iconified to item-view

@colourful-land what about <row-view> or <collapsed-view> or <mini-view> instead? I'm not attached to them, but feels like "item" (or "instance") doesn't have much meaning either.

bitcoinwarrior1 commented 4 years ago

@colourful-land changing view-iconified to item-view

@colourful-land what about <row-view> or <collapsed-view> or <mini-view> instead? I'm not attached to them, but feels like "item" (or "instance") doesn't have much meaning either.

@tomekalphawallet

SmartLayer commented 4 years ago

@colourful-land changing view-iconified to item-view

@colourful-land what about <row-view> or <collapsed-view> or <mini-view> instead? I'm not attached to them, but feels like "item" (or "instance") doesn't have much meaning either.

None of them suggests the items are selectable and multi-selectable. Imagine click and hold a mini-view. Previously the word "iconified" was chosen so the developers feel that they are selectable, but that was 'lost in translation'. Naming it <selectable-view> is, on the other hand, overdoing it, since sometimes the are actually displayed on the web as a reminder of what you have selected, not a selectable widget†.

On top of that, <row-view> and <mini-view> associates element with its presentation, therefore when presentation changes, they must, too (e.g. when they are used as a button†). You can argue iconified has the same problem (true. the word iconified was chosen not for the visual, but to hint it is used like a file-manager icon).

† Ask me if you have trouble imagining such a use-case.

<collapsed-view> works best for those item-views that are buttons which opens a collection of NFT. Not so portable to currency tokens. Also, it hints the view is just a collapsed version of the view, which, in an XML-way, should be <view collapsed="true"> instead. The reason <item-view> is not expressed as <view itemised="true"> is item-view is not a version of a view, it's a different thing‡, similar to <strawman> is not a version of <man>, but a different thing (while airman is a version of man, so <man aero="true">.

‡ used for different occassions, has different interaction, implementable with different mechanism (e.g. as a flyweight instead of reactJS component)

P.S. Why I don't remember having discussed this on the weekly meeting but only with @jzaki and @tomekalphawallet - I might have thought it was discussed with you guys already.

SmartLayer commented 4 years ago

The last commit resolves https://github.com/AlphaWallet/TokenScript-Examples/issues/29

bitcoinwarrior1 commented 4 years ago

17e8a06 deployed

bitcoinwarrior1 commented 4 years ago

deployed a5389a0