search

SmartTokenLabs / TokenScript

TokenScript schema, specs and paper
http://tokenscript.org
MIT License
242 stars 71 forks source link

RFC4912 required a <type> for a named type that defines a type #365

Closed SmartLayer closed 4 years ago

SmartLayer commented 4 years ago

  1. merge this together with https://github.com/AlphaWallet/TokenScript-Examples/pull/93

  2. Don't merge this in until both αW can handle the new schema.

hboon commented 4 years ago

@colourful-land should this require a new schema version since 2020/06 has already been shipped?

SmartLayer commented 4 years ago

@colourful-land should this require a new schema version since 2020/06 has already been shipped?

I was hoping to sneak that in since we can't do a new schema version until 2021. The αW can be written to handle both cases (<type> clearly defined or missing out). If you use xpath it should be easy to include the case with <type> or not

hboon commented 4 years ago

@colourful-land should this require a new schema version since 2020/06 has already been shipped?

I was hoping to sneak that in since we can't do a new schema version until 2021. The αW can be written to handle both cases (<type> clearly defined or missing out). If you use xpath it should be easy to include the case with <type> or not

We can do that in an updated app version. But the older versions in the install base will pick up the updated TokenScript files that includes this change like this [1] and break.

[1] https://github.com/AlphaWallet/TokenScript-Examples/pull/93/files

SmartLayer commented 4 years ago

@hboon exactly. How about we make αW android/ios both compatible with both format and wait a few weeks to see how many users upgraded before updating the Repo server?

hboon commented 4 years ago

@colourful-land I don't mind either way. You and @James-Sangalli decide then :)

SmartLayer commented 4 years ago 
2\. Don't merge this in until both αW can handle the new schema.

We are getting there. It's been 3 days and the 3.0.5 user base has just surpassed the 3.0.2 user base. I hope by the end of this week we can merge this in already.

SmartLayer commented 4 years ago

Usage of the Android version that didn't support <type> dropped to 15% (iOS should have fallen below this many days ago), so merging this in. I used merge instead of squash because this branch has a fork that is in PR to be merged soon