SmartTokenLabs / TokenScript

TokenScript schema, specs and paper
http://tokenscript.org
MIT License
242 stars 71 forks source link

Approved to move and Gave approval to move activities title are truncated #389

Open hboon opened 3 years ago

hboon commented 3 years ago

These 2 activities seem to frequently be associated with a large value that the following text is often (always?) truncated:

Approved to move \

and:

Gave approval to move \

Maybe truncate middle or hide the value completely for these 2 activities?

SmartLayer commented 3 years ago

I checked MetaMask and in their Activity, they simply hid the amount that is approved.

screenshot

Is it urgent? The reason I ask is that it seems all dapps today approved a maximum possible number (transaction generated by Uniswap). So I may update the code to show "Unlimited" instead. That requires a bit of JS detective work.

screenshot

hboon commented 3 years ago

Not urgent