SmartTokenLabs / TokenScript

TokenScript schema, specs and paper
http://tokenscript.org
MIT License
242 stars 71 forks source link

Indicate blockchain name or subnet/mainnet for Activities tab? #390

Closed hboon closed 3 years ago

hboon commented 3 years ago

The Transactions tab used to show the blockchain's name but the Activity tab doesn't for the standard ERC20 and ERC721 activities. Should we have some kind of indication so we at least know which is mainnet/testnets?

Transactions (before) Activity
colourfreak commented 3 years ago

We don't have much real estate in Activities. If this is not super important, I would just keep in for open activities (do not touch the main activity view).

In general:

But don't say anything about Mainnet as it makes it cluttered.

Screenshot 2020-09-29 at 08 32 00
hboon commented 3 years ago

Sorry, just thought of 1 point: since TokenScript authors can define their own activity card, showing the blockchain name or an indicator might be inconsistent and misleading, so maybe we can't show it at all, or we'll have to somehow enforce it for custom cards too?

What if we show a little triangle at 1 of the corners with the the blockchain's fill color (for all or just testnets)? Then it's easier to enforce for custom activity views.

I don't have an opinion on this, so happy to leave it untouched so long as it's a conscious decision (for now at least).

colourfreak commented 3 years ago

I would not show it at all. Or if you really want to, add this triangle. However, he needs discoverability = on tap reveal more info what is this triangle for.

Screenshot 2020-09-29 at 09 10 07
hboon commented 3 years ago

Nah, I don't mind. At least it's captured and thought through already. Closing. Feel free to re-open :)