SmartTokenLabs / attestation

Paper and implementation of blockchain attestations
MIT License
48 stars 10 forks source link

Liscon Improvements #220

Closed AW-STJ closed 2 years ago

AW-STJ commented 2 years ago

image

image Proposed text: Confirm network change on Metamask

image

Proposed text: Note: You might be prompted to connect Metamask again to complete the process

image

Proposed text: Confirm transaction to mint Liscon proof of ticket NFT for 'Ethereum Rinkeby Testnet'

The network names for mainnets can be : just Ethereuem, Polygon, Arbitrum, Optimistic etc.

The current attestation.id modal has a white background... is there a way to make it dark. Not sure whether it is possible. but just a question to consider. image

oleggrib commented 2 years ago

Proposed text: Confirm network change on Metamask

@AW-STJ Out of the box Metamask includes only Ethereum mainnet and testnets. In case if we want to use some other networks like Optimism/Poligon/etc.. then we have to add new network to the Metamask and then change current network to the New one. So we need both messages: "Add network", "Switch/change network"

The network names for mainnets can be : just Ethereuem, Polygon, Arbitrum, Optimistic etc.

Currently we use Testnets, for mainnets we can use those names. But before use it with mainnet we have to deploy contracts to the mainnets. (simple action, but need PrivateKey of accaount with appropriate ETH)

Background colour for Attestation.id modal

@foxgem can change background color (he need color code and he has to change fonts to the white and invert some other page elements) , it will affect only liscon attestation website, not legacy attestation.id

AW-STJ commented 2 years ago

@AW-STJ Out of the box Metamask includes only Ethereum mainnet and testnets. In case if we want to use some other networks like Optimism/Poligon/etc.. then we have to add new network to the Metamask and then change current network to the New one. So we need both messages: "Add network", "Switch/change network"

Then let the text be "Confirm the network on Metamask". Need not specify whether its addition or switch etc. I am trying to reduce the text. If Devcon team says otherwise, then we can change the text.

But before use it with mainnet we have to deploy contracts to the mainnets. (simple action, but need PrivateKey of accaount with appropriate ETH)

Okay, will get you the ETH required. Let me know how much it would be.

@foxgem can change background color (he need color code and he has to change fonts to the white and invert some other page elements) , it will affect only liscon attestation website, not legacy attestation.id

What I meant here is to change the background for the iFrame like a modal. Not sure whether this is possible or not. image

Not a must have, but a good to have. Let me know whether its hard to implement this.

foxgem commented 2 years ago

for @AW-STJ 's requirement

we can not control this because the iframe is called by the parent site. I guess the iframe is shown in a modal, if so, the parent site can control this.

AW-STJ commented 2 years ago

Thanks @foxgem for the response. @oleggrib - let us do it if that is possible and not hard to implement. If its harder and takes more time, then we can ignore this requirement.

oleggrib commented 2 years ago

@AW-STJ , styles and logos updated

Okay, will get you the ETH required. Let me know how much it would be.

let me check how to use ledger for deploy contracts.

oleggrib commented 2 years ago

@AW-STJ , I have ready code to use Ledger for different networks, so we can use tokens safely and deploy to the some mainnets

SmartLayer commented 2 years ago

Closing since all sub tasks are closed. Reopen if the sub-issues are not properly merged into main workstream.