Attestation.id is failing when trying to fully authenticate mock token - github examples

[nicktaras]

Steps:

get token from: https://tokenscript.github.io/token-negotiator-gh-pages/ticket-issuer-url-website/build/index.html

try to complete flow: https://tokenscript.github.io/token-negotiator-gh-pages/hotel-bogota-active-negotiation-website/build/index.html

bundle.js:124 POST https://backend-stage.attestation.id/api/attestation/magic-link net::ERR_ABORTED 400 createAndReturnAttestationFromMagicLink @ bundle.js:124 await in createAndReturnAttestationFromMagicLink (async) (anonymous) @ bundle.js:124 (anonymous) @ bundle.js:124 i @ bundle.js:124 s @ bundle.js:124 (anonymous) @ bundle.js:124 bundle.js:124 0x647935C1bfA643D27AFe0F32A5357975b56B771d bundle.js:124 0x647935C1bfA643D27AFe0F32A5357975b56B771d bundle.js:124 POST https://backend-stage.attestation.id/api/attestation/magic-link net::ERR_ABORTED 400

[foxgem]

I tried as the step described here. I got this error:

it seems the magic link attestation is created but validation failed. I have no idea about magiclink and this error. @oleggrib can you help this?

[nicktaras]

Thanks @foxgem.

@oleggrib - I hope your travel is going well. Would you have some time to take a look at this issue?

We are quite likely to be showing a live demo to a potential partner next Monday.

Could the mock attestations be outdated?

Thanks guys.

[micwallace]

Hey Nick,

I suspect we will need to update authenticator.js on our side to support the new schema. The packaged version already has the ability to use the new schema. I'll test this out a little later.

On 1 April 2022 3:19:53 pm AEDT, Nick @.***> wrote:

Thanks @foxgem.

@.*** - I hope your travel is going well. Would you have some time to take a look at this issue?

We are quite likely to be showing a live demo to a potential partner next Monday.

Could the mock attestations be outdated?

Thanks guys.

-- Reply to this email directly or view it on GitHub: https://github.com/TokenScript/attestation/issues/240#issuecomment-1085404538 You are receiving this because you are subscribed to this thread.

Message ID: @.***> -- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[jot2re]

The issue is an inconsistency between versions. The request in question has the legacy description "Linking Ethereum address to phone or email" whereas it is supposed to now be "Creating email attestation". The PR #237 fixes this issue.

[nicktaras]

Thanks @jot2re and @micwallace.

[nicktaras]

In general for these types of changes, let's put some time in next meeting to make some actions to stabilise the workflow of updates, so if attestation.id changes the examples will continue to function.

[nicktaras]

Thanks so much @oleggrib for your help towards the fix for the changes to attestation.id

"Can you try to build and use authenticator from branch "js_pr212" ? should fix the issue with attestation. Tell me if it help." comment from Oleh copied from conversation.

We'll try this and see if it resolves the issue.

[jot2re]

In general for these types of changes, let's put some time in next meeting to make some actions to stabilise the workflow of updates, so if attestation.id changes the examples will continue to function.

Yes, totally agree. I am sorry, it has been my fault of not getting things sufficiently integration tested before merging new changes.

[jot2re]

Please be aware it seems there is still a bug with the JS/TS code in this branch, on which I am waiting on some feedback from @oleggrib. Which is why I have not merged it yet.

[nicktaras]

That's ok Tore. Thanks so much for your help guys.

[jot2re]

I have made a new release of attestation.jar and authenticator.js, 0.3.17 and I have asked @foxgem to test and release it. I did a manual test (of the issuance of an attestation based on email) which worked. Although I have not made a manual test of the magicLink flow. @nicktaras if you will help me to make changes to the examples in the right places, to allow for a test of the flow using a locally hosted attestation.id instance, I would be happy, since it would allow me to better manually test changes before releases.

[micwallace]

Hey all, the latest build of token negotiator now includes the attestation NPM package and is validating correctly with attestation.id. I have had to include old versions of SignedDevconTicket for compatibility, so that need to be looked at to get the updated versions working. Please see #239