SmartTokenLabs / tokenscript-engine

A JavaScript library for embedding tokenscript functionality in applications.
Other
2 stars 1 forks source link

Feed Cat via T-Link #47

Closed nicktaras closed 3 weeks ago

nicktaras commented 3 weeks ago

Using T-Link via Twitter there are 38 pending MetaMask events when using another wallet to make the TX to feed the cat.

I’ve placed this issue in this repo, where it’s looks to be caused by the TS engine itself - from attempting transactions as a non-owner of the token.

cc: @zhangzhongnan928

micwallace commented 3 weeks ago

@nicktaras Seems like the RPC error isn't being correctly forwarded back to the engine. It should say that the user is not the cat owner. I'm guessing you receive "Internal JSON-RPC error." too?

zhangzhongnan928 commented 3 weeks ago

@nicktaras Seems like the RPC error isn't being correctly forwarded back to the engine. It should say that the user is not the cat owner. I'm guessing you receive "Internal JSON-RPC error." too?

https://x.com/TantanFu122765/status/1844177981943758888 This one

futantan commented 3 weeks ago

CleanShot 2024-10-15 at 19 17 43@2x

I tried with another wallet, it looks good on my side. hi @zhangzhongnan928 @micwallace are you able to reproduce this?

zhangzhongnan928 commented 3 weeks ago

https://x.com/TantanFu122765/status/1835822673571762177 I clicked mint button, and it created 26 TX in metamsk

Screenshot 2024-10-15 at 7 40 19 pm Screenshot 2024-10-15 at 7 43 39 pm

@futantan

futantan commented 3 weeks ago

https://github.com/user-attachments/assets/2d9bc9e6-7391-4daf-821f-5ec4800d0cf0

works on my side... 🤔

zhangzhongnan928 commented 3 weeks ago

Does it because I’m not the tapp owner?

On Tue, Oct 15, 2024 at 20:01 Tantan Fu @.***> wrote:

https://github.com/user-attachments/assets/2d9bc9e6-7391-4daf-821f-5ec4800d0cf0

works on my side... 🤔

— Reply to this email directly, view it on GitHub https://github.com/SmartTokenLabs/tokenscript-engine/issues/47#issuecomment-2413303578, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIB23V5SFT5QMFRDB36FH7LZ3TKVNAVCNFSM6AAAAABP2EXFGOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJTGMYDGNJXHA . You are receiving this because you were mentioned.Message ID: @.***>

zhangzhongnan928 commented 3 weeks ago

https://github.com/user-attachments/assets/1ff1b1b8-091d-48fb-8bd7-a583ad2b83bf

micwallace commented 3 weeks ago

@zhangzhongnan928 what is the Twitter post URL?

micwallace commented 3 weeks ago

@zhangzhongnan928 @futantan I think I know the problem, will investigate further tomorrow.

zhangzhongnan928 commented 3 weeks ago

@zhangzhongnan928 what is the Twitter post URL?

https://x.com/TantanFu122765/status/1835822673571762177

micwallace commented 3 weeks ago

@zhangzhongnan928 @futantan Oddly I'm not seeing the problem and was able to mint a token successfully. There were no other transaction requests.

zhangzhongnan928 commented 3 weeks ago

@zhangzhongnan928 @futantan Oddly I'm not seeing the problem and was able to mint a token successfully. There were no other transaction requests.

But I got same TX repeat 10+ times.

micwallace commented 3 weeks ago

@zhangzhongnan928 I've added a commit to fix the issue in the TLink extension, so it will be resolved next time @futantan does a release.

futantan commented 3 weeks ago

Thank you @micwallace new version 0.3.6 has been released