search

SmartZoos / Toolset

Gaming platform for SmartZoos project
MIT License
0 stars 1 forks source link

Information activity item uses "Question" marker #145

Closed PatriciaMoller closed 7 years ago

PatriciaMoller commented 7 years ago

screenshot_20171003-120328

I'm pretty sure they had a "!" icon before we proposed the change back in #115. The Information was to be excepted from the change.

pjotrsavitski commented 7 years ago

They had different icons for each question type instead. I am not sure what the issue is about though.

PatriciaMoller commented 7 years ago

The Information type was going to keep the !-icon, so it wouldn't be misunderstood as a question.

pjotrsavitski commented 7 years ago

This is the issue: #118 It does not mention anything like that. Also, there was no SVG icon for the case, thus it should probably not have been so.

This is the state of the code prior to the commit that made the change: https://github.com/SmartZoos/Toolset/tree/64cc41767c3cf4d75b28e4900a37f975b970f2c5/public/img/icons/item

PatriciaMoller commented 7 years ago

It was written in #115, that the information marker was to remain.

I made new variants here It had probably slipped my mind that it would have needed extra icons in order to be consistent with the rest.

pjotrsavitski commented 7 years ago

The out of reach icon seems to be having the question mark. Should that be so or or would it still have some other symbol?

PatriciaMoller commented 7 years ago

Fixed it.