search

SmartZoos / Toolset

Gaming platform for SmartZoos project
MIT License
0 stars 1 forks source link

Language select propmt? #166

Closed PatriciaMoller closed 6 years ago

PatriciaMoller commented 6 years ago

Is it possible to prompt a language select? Jens mentioned that the site by default being in English might become difficult for smaller children and other non-English speakers. Since the language select on mobile is "hidden" in the menu, maybe it would be good to have an early clearly visible choice

pjotrsavitski commented 6 years ago

I would probably prefer to implement locale detection based on browser settings. Although, it might not always give 100% correct results.

How do you imagine the language select? Would it be a popover, tooltip or a modal dialog? Would that not be a bit intrusive?

PatriciaMoller commented 6 years ago

Locale based sounds nice, yes. But it could probably also cause issues with eg tourists from another countries.

A popover box would probably be a bit intrusive yes, but also very direct and clear. language select

Another option would be a landing page: (this is a very old example. Flags should be replaced by text): languageselect

pjotrsavitski commented 6 years ago

Locale is based on OS and/or browser language (even more complicated to be honest). For my case it should show either English or Estonian, even if I am at Skansen.

The popover/modal should only be shown on mobile devices with really small screen (phones).

Sent from my iPhone

On 9 Nov 2017, at 13:15, PatriciaMoller notifications@github.com wrote:

Locale based sounds nice, yes. But it could probably also cause issues with eg tourists from another countries.

A popover box would probably be a bit intrusive yes, but also very direct and clear.

Another option would be a landing page: (this is a very old example. Flags should be replaced by text):

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

PatriciaMoller commented 6 years ago

Oh, I misunderstood it as from geographic position. OS seems good.

How come it should only be shown on small screens?

pjotrsavitski commented 6 years ago

Easy enough. On bigger screens/higher resolutions (starting from iPad), the language choice menu is not hidden. So, it does not really make any sense to show that dialog.

Getting that from the IP address requires making a query to a third-party service, that does not seem meaningful.

pjotrsavitski commented 6 years ago

Language negotiation has been implemented. It might be sufficient to deal with the situation.

The implementation logic is trying to detect the best possible language, with fallback to English. This means that if the first preference is French, second one is Swedish and third one is English. The system should choose Swedish as it comes before English, but French is not a supported language.

The change should arrive at the server in about an hour or so.

pjotrsavitski commented 6 years ago

Implemented language detection seems to be working just fine and should be enough.