search

Smarteon / loxone-java

Java implementation of the Loxone™ communication protocol (Web Socket)
BSD 3-Clause "New" or "Revised" License
15 stars 10 forks source link

Introduced the use of lombok for Control hierarchy, Category & Room #166

Closed TCke83 closed 2 years ago

TCke83 commented 2 years ago

First version of lombok use

codecov[bot] commented 2 years ago

Codecov Report

Merging #166 (f1358c2) into master (027fc30) will increase coverage by 0.18%. The diff coverage is 75.00%.

:exclamation: Current head f1358c2 differs from pull request most recent head 0dc7e2e. Consider uploading reports for the commit 0dc7e2e to get more accurate results

@@             Coverage Diff              @@
##             master     #166      +/-   ##
============================================
+ Coverage     80.22%   80.41%   +0.18%     
  Complexity      650      650              
============================================
  Files            86       86              
  Lines          1755     1751       -4     
  Branches        141      141              
============================================
  Hits           1408     1408              
+ Misses          271      266       -5     
- Partials         76       77       +1
Impacted Files Coverage Δ
src/main/java/cz/smarteon/loxone/app/Category.java 75.00% <75.00%> (-25.00%) :arrow_down:
src/main/java/cz/smarteon/loxone/app/Control.java 66.66% <75.00%> (ø)
src/main/java/cz/smarteon/loxone/app/Room.java 75.00% <75.00%> (-25.00%) :arrow_down:
.../main/java/cz/smarteon/loxone/LoxoneWebSocket.java 67.69% <0.00%> (+2.65%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jimirocks commented 2 years ago

The last thing - could you please additionally introduce nullability annotations to the Category and Room classes?