Smartling / api-sdk-net

.Net SDK for integrating with the Smartling API. The Smartling API allows developers to upload language specific resource files and download the translations of those files for easy integration within their application. http://docs.smartling.com
Apache License 2.0
1 stars 6 forks source link

AuditLog class contains too many details of sitecore integration #12

Closed dimitrystd closed 5 years ago

dimitrystd commented 5 years ago

Follow up for https://github.com/Smartling/sitecore-localization-module/issues/519

I would like to keep SDK generic (not as primary SDK for sitecore connector). The new AuditLog.cs contains fields that are related to sitecore only. Smartling audit API has single mandatory time field. So i think SDK should be responsible for:

Everything else (fields) should be optional and come from consumer (sitecore connector). In this case SDK will not force user to use recommended field names but it's payback for "generic" implementation.

dotnetrocks commented 5 years ago

Merged.