Ampersand in fileUri is not escaped correctly

[dimitrystd]

Steps:

• Upload file with name D & G.xml
• Now call GetLastModified with fileUri above

Actual: You will get error

{
    "response": {
        "code": "VALIDATION_ERROR",
        "errors": [
            {
                "key": "unknown.field",
                "message": "The field  G.xml was not expected. Please consult the documentation to verify the fields you are submitting.",
                "details": {
                    "field": " G.xml"
                }
            },
            {
                "key": "file.not.found",
                "message": "The file \"D \" could not be found",
                "details": {
                    "field": "fileUri"
                }
            }
        ]
    }
}

This is because smartling got

https://api.stg.smartling.net/files-api/v2/projects/xxx/file/last-modified?fileUri=D%20&%20G.xml

You may notice that only spaces were urlencoded by & is unencoded. As result FAPI thinks that you send 2 parameters

• fileUri=D%20
• %20G.xml

DoD:

• Escape parameter names and values for ALL GET queries (not only for FAPI) All APIs that use PrepareGetRequest() method
• Update GetRequestStringBuilder with using Uri class instead of just concat strings. We must be sure that result URL will be correct and doesn't depend on what user saved in configuration (leading\trailing slaches)
• Write tests that verify webrequest uses properly escaped parameters. I added ShouldEscapeParametersInLastModified but it test PrepareGetRequest() which is not correct. Ideally we should test WebRequest that is returned by PrepareGetRequest()

[dimitrystd]

Commits above were made for File API only. We may expect similar bug for other APIs. I will update DoD in the description.

[dotnetrocks]

@dimitrystd So is it still open or closed?

[dimitrystd]

I closed it but ideally we should fix other places and add tests