Closed dimitrystd closed 5 years ago
Commits above were made for File API only. We may expect similar bug for other APIs. I will update DoD in the description.
@dimitrystd So is it still open or closed?
I closed it but ideally we should fix other places and add tests
Steps:
D & G.xml
GetLastModified
with fileUri aboveActual: You will get error
This is because smartling got
You may notice that only spaces were urlencoded by
&
is unencoded. As result FAPI thinks that you send 2 parametersfileUri=D%20
%20G.xml
DoD:
PrepareGetRequest()
methodGetRequestStringBuilder
with usingUri
class instead of just concat strings. We must be sure that result URL will be correct and doesn't depend on what user saved in configuration (leading\trailing slaches)ShouldEscapeParametersInLastModified
but it testPrepareGetRequest()
which is not correct. Ideally we should testWebRequest
that is returned byPrepareGetRequest()