Smartling / api-sdk-net

.Net SDK for integrating with the Smartling API. The Smartling API allows developers to upload language specific resource files and download the translations of those files for easy integration within their application. http://docs.smartling.com
Apache License 2.0
1 stars 6 forks source link

Change API call - add locale to job #7

Closed dimitrystd closed 3 years ago

dimitrystd commented 6 years ago

The original documentation was

POST /jobs-api/v3/projects/{projectId}/jobs/{translationJobUid}/locales/{localeId}?syncContent=true|false

and we implemented it exactly like this. But we just discovered that it doesn't work as expected. Actually, we have 2 issues: 1) Boolean value should be in lower case but we sent

    /jobs-api/v3/projects/a73055a7e/jobs/dx0nruzxtjmh/locales/ko-KR?syncContent=False
Personally, i think API should be case insensitive but they are not

1) Parameter should be in body instead of query string. So proper documentation is

    POST /jobs-api/v3/projects/{projectId}/jobs/{translationJobUid}/locales/{localeId}
    {
        "syncContent" : true|false
    }
dimitrystd commented 3 years ago

Close it because we don't use this method anymore. But bug is probably still there.