Smartling / ios-lqa-sdk

Smartling Mobile SDK for iOS (Mobile Context, In App Review, Mobile Delivery Network)
Other
3 stars 2 forks source link

Podspec is incorrect #8

Open lilyball opened 6 years ago

lilyball commented 6 years ago

The podspec you publish for this repository is incorrect. Your publised podspec JSON declares

  "libraries": [
    "Smartling"
  ],

However the "libraries" key is for system libraries, i.e. libraries that you need to link against if you use this pod. What you want is "vendored_libraries". The problem with just using "libraries" is it means any nested target that is set to just inherit search paths and inherits a dependency on your pod will attempt to link against your static library (which will fail at link time) even though it shouldn't. For example, given the following Podfile:

target "MyApp" do
    pod 'Smartling'
    target "MyAppTests" do
        inherit! :search_paths
    end
end

The MyAppTests target will fail to compile with a linker error, due to inserting -lSmartling into OTHER_LDFLAGS.

JaviSoto commented 6 years ago

Any updates on this?