SmartlyDressedGames / Legally-Distinct-Missile

Fork of Rocket for Unturned maintained by the game developers.
MIT License
79 stars 29 forks source link

Double print message to Rocket.log #28

Closed warren39 closed 3 years ago

warren39 commented 4 years ago

API Rocket.Core.Logging.Logger.Log(string message) will print message twice to the log file. Is that Bug or ?

Rocket.log

[2020/8/2 10:05:50] [Info] PVP >> Init.. [2020/8/2 10:05:50] [Info] PVP >> Init.. [2020/8/2 10:06:44] [Info] PVP >> PostLevelLoaded: 2 [2020/8/2 10:06:44] [Info] PVP >> PostLevelLoaded: 2

Trojaner commented 4 years ago

I can confirm this

SDGNelson commented 4 years ago

Off the top of my head it might be writing to the log file, and then getting logged again once it goes through the Unturned console. Ideally newer could should use the built-in CommandWindow or UnturnedLog functions - Rocket is routed through those, and all of the base game logging uses them.

joeymisfit commented 4 years ago

@SDGNelson I can also confirm this issue, I work in customer service for a game server host and it's a constant issue. Might I also add the printed messages start when the command /more starts loading. Is there a way to possibly fix the duplication glitch? dupe

SDGNelson commented 4 years ago

Alright, since several people have asked about it I will see about sorting it out for the next update.

joeymisfit commented 4 years ago

@SDGNelson Was the update supposed to be apart of this mornings update?

SDGNelson commented 4 years ago

Nope - the update this morning was to address issues with signs that spread wildly on Sunday. Here are more details: https://github.com/SmartlyDressedGames/Unturned-3.x-Community/issues/1933#issuecomment-671163285

SDGNelson commented 3 years ago

This should be fixed in the next update. Here is the commit that fixes it: https://github.com/SmartlyDressedGames/Legally-Distinct-Missile/commit/126a827507d7037f9bb7aaa7371a4ff3748839d2

joeymisfit commented 3 years ago

Thank you for fixing this, it's been such a pain with the double print.