search

SmartlyDressedGames / Legally-Distinct-Missile

Fork of Rocket for Unturned maintained by the game developers.
MIT License
79 stars 29 forks source link

[Bug] When it will be fixed?! #39

Closed surv0013 closed 3 years ago

surv0013 commented 3 years ago

Event onCheckValid is [Obsolete] or what? Why does one event overlap another? Did you want to remove it? If so, why is there no attribute [Obsolete]? Why is the old event used in Rocket? Simply because of this, it is not possible to use the new event normally, because in this case the Rocket prefixes disappear.

P.S. Rocket v4.3.9.12

image image

SDGNelson commented 3 years ago

The WithExplanation variant was added a long time ago when an explanation string was added for plugin kicks. It superseded the older event because ideally plugins should be providing a reason.

surv0013 commented 3 years ago

Problem is that Rocket itself uses a variant without explanation, as a result of this, if you load the plugin with an explanation, the Rocket event (CheckValid) will stop working.

And if the Rocket event stops working, then besides the fact that there will be no prefixes, all plugins that work on the Rocket event will also stop working.

This problem can be fixed in two ways: either remove the event overriding (if else) so that they both works, or change the event in Rocket (onCheckValid -> onCheckValidWithExplanation).

P.S. Don't tell me the appearance of the second event, I have been "playing" your game for 7 years now and I know where it came from. Of course, during this time I have accumulated a ton of questions about the game code, but more on that another time. :D

SDGNelson commented 3 years ago

No need to be rude. 🙄

In general the intention with game plugin improvements has been for plugins to bind the game events rather than Rocket events, but I suppose this should be changed in Rocket for better backwards compatibility.

surv0013 commented 3 years ago

No need to be rude. 🙄

I'm not rude, I'm angry... I can understand the bugs that appeared after the update, but I do not understand the bugs that are already several years old. image

SDGNelson commented 3 years ago

Nobody has raised an issue about it before. https://github.com/SmartlyDressedGames/Legally-Distinct-Missile/issues?q=is%3Aissue+onCheckValid https://github.com/SmartlyDressedGames/Unturned-3.x-Community/issues?q=is%3Aissue+onCheckValid

lion

surv0013 commented 3 years ago

Ok you convinced me

image

rube200 commented 3 years ago

It has not explicit but #15 could have fixed that issue (it was one of the reasons of that pr)