Code cleanup. - Githubissues

SmartlyDressedGames / Legally-Distinct-Missile

Fork of Rocket for Unturned maintained by the game developers.

MIT License

80 stars 33 forks source link

Code cleanup. #6

Closed cemahseri closed 4 years ago

cemahseri commented 4 years ago

First commit;

Rocket.Unturned.Launcher

Upgraded Rocket.Unturned.Launcher to new csproj format.
Made RocketLauncher class internal, since it's not been accessed by outside.
Renamed consoleReader field to _consoleReader.
Renamed fileSystemWatcher_Changed method to FileSystemWatcher_Changed.
Fixed poor variable namings.

Second commit;

Rocket.Unturned

Upgraded Rocket.Unturned to new csproj format.

Environment.cs

General cleanup.

U.cs

Renamed rocketGameObject field to _rocketGameObject.
Renamed defaultTranslations field to DefaultTranslations.
Renamed bindDelegates method to BindDelegates.
Rearranged order of properties, fields, methods, etc.

UnturnedConsole.cs

General cleanup.

UnturnedConsoleWriter.cs

Made _consoleOutput field readonly.
Made _consoleError field readonly.
Made _streamWriter field readonly.

Third commit;

Made lot's of cleanup. Output of methods and properties' names aren't changed. Just removed unused parts and reduntant code.

SDGNelson commented 4 years ago

Thanks for the submission Daemonn. These look like good changes, but they fall outside the planned scope of this repo. Feel free to make them in a fork! I have clarified the goals in the readme now, namely:

The goals of this repository are to maintain compatibility with Unturned, maintain backwards compatibility with plugins, and fix bugs. Changes outside that scope will be made to the Unturned API rather than reworking the Rocket API. New plugins should ideally be using the game API where possible.