SmartlyDressedGames / Legally-Distinct-Missile

Fork of Rocket for Unturned maintained by the game developers.
MIT License
77 stars 29 forks source link

General optimizations, rework ... #7

Closed rube200 closed 4 years ago

rube200 commented 4 years ago

First commit:

UnturnedSettings.cs

AutomaticSaveWatchdog.cs

UnturnedPlayerMovement.cs

PluginUnturnedPlayerComponentManager.cs

Third commit:

U.cs

PluginUnturnedPlayerComponentManager.cs

UnturnedPlayer.cs

(I tried to maintain maximum compatibility)

SDGNelson commented 4 years ago

Thanks for the submissions rube200!

You raise good points about the autosave timer and DontDestroyOnLoad, so those have been fixed for the next release.

I feel that the other changes fall outside the scope of this repo's goals, so I have clarified in the readme:

The goals of this repository are to maintain compatibility with Unturned, maintain backwards compatibility with plugins, and fix bugs. Changes outside that scope will be made to the Unturned API rather than reworking the Rocket API. New plugins should ideally be using the game API where possible.

Will follow-up about Observatory in the other PR.