SmartlyDressedGames / Legally-Distinct-Missile

Fork of Rocket for Unturned maintained by the game developers.
MIT License
76 stars 30 forks source link

/v command not working properly with colored vehicles after 3.24.4 update #75

Open ItsRodrigoAl opened 2 weeks ago

ItsRodrigoAl commented 2 weeks ago

Mostly because today's update is related with vehicles. This is also affecting "old" plugins which does things with vehicles, like garage and kits plugins. With RocketMod for example, I can't do /v quad anymore, but I can do /v otter, basically because quads have color variants, but otter doesn't have variants.

With garage plugins, the vehicles do not save the vehicle colors (I guess is something they need to fix themselves), and for kits plugins when trying to get a vehicle with color variants, it works just weird. So I guess this new thing of colors doesn't have a good backward compatibility with "old" plugins (not updated yet plugins)

SDGNelson commented 2 weeks ago

It looks like this is because CommandV.cs line 85 casts the asset to VehicleAsset. When looking up certain legacy IDs it will receive a VehicleRedirectorAsset instead.

Personally, I'm pretty happy with the level of backwards compatibility in this update. The aspects you mention should be straightforward for plugin devs to fix. I see a lot of people say I should be more willing to break things. ¯\_(ツ)_/¯

aman7 commented 1 week ago

i am also having similar problem. rocketvehicle

SDGNelson commented 1 week ago

Should be fixed in this commit in the simplest way possible: https://github.com/SmartlyDressedGames/Legally-Distinct-Missile/commit/183c523d33e846699eefddbec502471cec1ffd95

SDGNelson commented 1 week ago

Oh, I haven't patched the game itself yet, sorry. If you'd like the Rocket fix in particular you can download it here: https://github.com/SmartlyDressedGames/Legally-Distinct-Missile/releases/tag/v4.9.3.17

I'm going to aim to release the patch first thing tomorrow morning and include fixes for any other issues raised in the next few hours.

aman7 commented 1 week ago

i found it, thank you very much

liebesleid-eth commented 1 week ago

Keep breaking things as needed! let all the old plugins become sacrifices in the name of progress and improvement! \ :v /