SmartlyDressedGames / Unturned-3.x-Community

Community portion of the Unturned-3.x repo. If you have access to the source code you can find it here:
https://github.com/SmartlyDressedGames/Unturned-3.x/
84 stars 18 forks source link

Please add the event OnPlayerUpdateOxygen #4389

Closed MrRousek closed 3 months ago

MrRousek commented 3 months ago

Similar events exist in UnturnedPlayerEvents, but there is no Oxygen

MrRousek commented 3 months ago

I understand that this is from the RocketMod code. But there was already practice when you updated RocketMod command

Jdance-Media commented 3 months ago

But... Isn't that just PlayerLife.onOxygenUpdated?

I feel like this is a issue/request more fitting for the actual LDM repository. You could make a PR to both LDM and RMF and see if they get merged.

SDGNelson commented 3 months ago

Thanks Jdance. Also, it was probably somewhat related to the differences between the mostly-predicted-only vs always-have-been-replicated life properties.

rube200 commented 3 months ago

There is onOxygenUpdated but could we get a global version of it?

Jdance-Media commented 3 months ago

Well, the global version is technically the life updated event, which is triggered for all the stats I think.