SmartlyDressedGames / Unturned-Docs

Documentation for Unturned's modding features.
135 stars 49 forks source link

Fixed missing requirement for quests #281

Closed ai-kana closed 5 months ago

ai-kana commented 1 year ago

The quest condition in "conditions.rst" was missing a required argument of Logic. Maybe I am wrong but I absolutely cannot get my NPC to function without that argument, I tested both it being: Quest Active; Logic Not_Equal, and Quest None; Logic Equal. Both of which functioned as intended.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

MoltonMontro commented 1 year ago

It may make more sense for this information to be listed at the top of the doc (where Condition_#_Type and Condition_#_Logic are documented) – as to avoid having to repeat it for a majority of the properties.

ai-kana commented 1 year ago

Very possibly but it made me spend a lot of time trying to figure out what was wrong with it and I think it would be all around easier to just list all the possible arguments for each condition.

SDGNelson commented 1 year ago

Currently every condition type requires Logic be specified

ai-kana commented 1 year ago

It never states that in the documentation, and that has caused me much confusion. There is nothing wrong with being verbose and putting it on every condition if it saves time and communicates what is needed well. I can amend my pull request to add such if you'd like.