search

SmartlyDressedGames / Unturned-Docs

Documentation for Unturned's modding features.
135 stars 49 forks source link

Load custom CSS #324

Closed MoltonMontro closed 2 months ago

MoltonMontro commented 2 months ago

conf.py would now be able to load custom CSS and JS from _static.

Currently, css/custom.css is loaded. The only styling rule is to add word-wrapping to tables (on desktop monitors, i.e. where horizontal scrollbars are undesirable).

SDGNelson commented 2 months ago

For comparison I checked the tables on the Gun Asset page: with custom style without custom style

It looks to me like it may have had an unintended effect: With the page at full size the Requires_NonZero_Attachment_Caliber name is wrapping the 'r' to a new line. Shrinking the page width it does appear to be removing the horizontal scrollbar as-intended, however.

I'm not sure I understand about the intention though: I see the page width threshold is 769 px. I would guess most desktop users have screens wider than that, IIRC the Steam Hardware Survey reports 1920x1080 as the most common resolution. What's your thought process behind the change?

MoltonMontro commented 2 months ago

For @media query breakpoints, a min-width of 769px would be the start of laptops / small screens (going larger). Basically, most non-touch devices (where horizontal scrolling is more likely to cause information to be missed).

These commits were part of a separate PR, but I broke them off because they felt tangential. The original PR was expanding on introductory articles, and some revisions had tables where horizontal scrollbars would've been unavoidable. E.g., moving launch options into tables a la Godot or Unity.

My assumption is that the table column widths specified are too small for that column, causing it wrap instead of automatically adjust these widths. 😞

Technically we could just strip all manually-specified column widths, or adjust them as needed, or just have a custom class to add wrapping to tables that would want it. But the CSS file included here is definitely more proactive than reactive (no current content should need it, at 1920x1080px screens).

Unsure where to go from here with the PR. Maybe close for now, or I could strip the one CSS rule (leaving the file blank)?

MoltonMontro commented 2 months ago

New push comments out this styling rule (for now?). May revisit in the future.