search

SmashTapsOS / reactjs-videobg

Easily add background videos to react web apps
MIT License
50 stars 12 forks source link

Attributes added to VideoBg tag #2

Closed Agent9G closed 5 years ago

Agent9G commented 5 years ago

How am i to add attributes to this tag.

i currently have such: <VideoBg loop={false} muted={false} poster={...}>

I am getting the warning fro both 'Failed prop type: Invalid prop loopof type booleansupplied to j, expected string.

Agent9G commented 5 years ago

The other thing, is it possible to make the poster show after the video has played?

samAbeywickrama commented 5 years ago

The other thing, is it possible to make the poster show after the video has played?

This is not supported, Planing to implement this soon :)

samAbeywickrama commented 5 years ago

How am i to add attributes to this tag.

i currently have such: <VideoBg loop={false} muted={false} poster={...}>

I am getting the warning fro both 'Failed prop type: Invalid prop loopof type booleansupplied to j, expected string.

I have done a silly mistake in proptype validation in https://github.com/samAbeywickrama/reactjs-videobg/blob/master/src/VideoBg.js 😅

  loop: PropTypes.string,

It has to be 

  loop: PropTypes.bool,

I will add a fix to this and do a release asap :)

samAbeywickrama commented 5 years ago

:tada: This issue has been resolved in version 1.2.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

rasulacaldera commented 5 years ago

The other thing, is it possible to make the poster show after the video has played?

This is not supported, Planing to implement this soon :)

Working on this here #4

Agent9G commented 5 years ago

The other thing, is it possible to make the poster show after the video has played?

This is not supported, Planing to implement this soon :)

Solid!

Agent9G commented 5 years ago

How am i to add attributes to this tag. i currently have such: <VideoBg loop={false} muted={false} poster={...}> I am getting the warning fro both 'Failed prop type: Invalid prop loopof type booleansupplied to j, expected string.

I have done a silly mistake in proptype validation in https://github.com/samAbeywickrama/reactjs-videobg/blob/master/src/VideoBg.js 

  loop: PropTypes.string,

It has to be

  loop: PropTypes.bool,

I will add a fix to this and do a release asap :)

You da champ!

Thank you.