Fixing favicon location

Smashing / smashing

The exceptionally handsome dashboard framework in Ruby and Coffeescript.

https://smashing.github.io/

MIT License

3.24k stars 323 forks source link

Fixing favicon location #135

Closed gregology closed 5 years ago

gregology commented 5 years ago

assets within the public directory are mounted at / not /public/

kinow commented 5 years ago

I created a dashboard, then smashing start, and http://localhost:3030/favicon.ico appears to be serving the file alright? Did you find an issue in a server trying to locate the favicon.ico file? I wonder if I am missing anything.

gregology commented 5 years ago

@kinow, that's correct. But layout.erb references /public/favicon.ico instead of /favicon.ico. /public/favicon.ico doesn't exist.

kinow commented 5 years ago

Oh, I see it now. Thanks @gregology ! Approving and will leave it open for a while to see if there are no objections for merging this.

kinow commented 5 years ago

No objections raised here, and the Travis failure is related to #138 . LGTM