Smashing / smashing

The exceptionally handsome dashboard framework in Ruby and Coffeescript.
https://smashing.github.io/
MIT License
3.22k stars 324 forks source link

:bug: Use {} as fallback for history.yaml. #137

Closed YtvwlD closed 5 years ago

YtvwlD commented 5 years ago

Otherwise, YAML.load_file returns false for an empty file, which messed the whole thing up.

kinow commented 5 years ago

Hmmm, unfortunately two build failures in Travis @YtvwlD . Otherwise ready to merge I think

YtvwlD commented 5 years ago

These failures also happen with the current master: https://travis-ci.org/YtvwlD/smashing

kinow commented 5 years ago

I was afraid of that. Let me find some time to investigate it later and then we can rebase this one and merge.

kinow commented 5 years ago

Thinking twice, it actually passes in one of the Ruby versions. So let's merge and will sort the build in Travis later in a separate issue :+1:

YtvwlD commented 5 years ago

Thank you. :)

kinow commented 5 years ago

Thank you for your contribution @YtvwlD !