Smashing / smashing

The exceptionally handsome dashboard framework in Ruby and Coffeescript.
https://smashing.github.io/
MIT License
3.24k stars 323 forks source link

Fix Travis build on master #138

Closed kinow closed 5 years ago

kinow commented 5 years ago

Found while reviewing #137 that the master branch is currently broken.

It should be some dependency, or maybe something in Travis. So whoever finds time to have a look and fix it, it'd be much appreciated (currently overseas with limited bandwidth, but will investigate it otherwise when I return home)

YtvwlD commented 5 years ago

This just applies to Ruby versions 2.2 and 2.3. They aren't being supported, anymore.

Perhaps we should just remove them from the CI matrix and add 2.5 and 2.6 instead?

kinow commented 5 years ago

Perhaps we should just remove them from the CI matrix and add 2.5 and 2.6 instead?

Could be. Let's wait for others to chime in. Might drop a note to gitter later if there's no response here.