Fix bug causing AnimatedValue to freeze after same value is entered

Smashing / smashing

The exceptionally handsome dashboard framework in Ruby and Coffeescript.

https://smashing.github.io/

MIT License

3.22k stars 324 forks source link

Fix bug causing AnimatedValue to freeze after same value is entered #155

Closed kotaweav closed 4 years ago

kotaweav commented 4 years ago

There appears to be a bug in Dashing.AnimatedValue which causes the AnimatedValue to freeze if the new value is equal to the current. The source of the bug seems to be due to the comparison in num == to being between a float and a string. By default, CoffeeScript compiles == to Javascript's ===. Instead, if we use backticks, we can use a "raw Javascript" command which allows us to call ==.

kinow commented 4 years ago

Added a NOTE to the code, and also the changelog entry. Will be included in the next release. Thanks @femtogram !