🐛 Remove websocket connections that have been closed in send_event

Smashing / smashing

The exceptionally handsome dashboard framework in Ruby and Coffeescript.

https://smashing.github.io/

MIT License

3.22k stars 324 forks source link

🐛 Remove websocket connections that have been closed in send_event #177

Closed ssgelm closed 3 years ago

ssgelm commented 3 years ago

Currently, if a connection is not dropped gracefully its websocket stays in the connection list. This means that when send_event runs it throws an IOError when it gets to that connection, causing all subsequent sockets in the list to not receive updated events. This commit instead rescues the error and removes the closed websocket from the list of connections.

kinow commented 3 years ago

Added a changelog and merged. Will be included in next 1.3.1 release. Thanks a lot @ssgelm !