search

Smashing / smashing

The exceptionally handsome dashboard framework in Ruby and Coffeescript.
https://smashing.github.io/
MIT License
3.22k stars 324 forks source link

Relax dependencies 🔧 🍎 #178

Closed dylanratcliffe closed 3 years ago

dylanratcliffe commented 3 years ago

This PR relaxes many of the dependencies that smashing has. This should allow users to upgrade dependant gems without requiring a release of smashing. A good example of where this is require is in #174

In #174 we need to upgrade to thin >= 1.8.0 in order to be able to compile it against XCode 12 however since Smashing was dependant on version ~> 1.7.2 that means we could only use releases that were >= 1.7.2 and < 1.8.0 i.e. we can't use the new version.

This relaxes many dependencies to allow users to upgrade to new feature releases, but not to the next X (breaking) release. Given that breaking changes should require a major release as per semver we should expect that this wouldn't cause any issues.

I did have a look through the commit messages to see if there was any specific reason why the dependencies were so strict and couldn't find any. If there are good reasons though please let me know.

kinow commented 3 years ago

@dylanratcliffe I noticed Travis was not running. Had a bit of spare time during lunch time today, so migrated master to GH actions but used the Ruby version from this PR :+1: push-forced after rebasing your branch.

kinow commented 3 years ago

CI passed, merging :rocket: