Closed Ragnaraven closed 1 year ago
I also changed the build.gradle. The gradle appears to use java 17, but there was a command arg that appears to no longer exist, so I removed it as I could not launch the project with it.
The argument never existed in the first place - it is intrinsic to DCEVM-based JDKs (so these days only the jetbrains runtime)
I also changed the build.gradle. The gradle appears to use java 17, but there was a command arg that appears to no longer exist, so I removed it as I could not launch the project with it.
The argument never existed in the first place - it is intrinsic to DCEVM-based JDKs (so these days only the jetbrains runtime)
That's interesting. Thinking back, I think I did set it to coretto 17 when prompted by IJ. Is that perhaps why I had an issue with it? I can happily walk the build.gradle changes back if interested. Please let me know.
Also, are you certain that the bugfix should be done through Alchemistry and not over at AlchemyLib? Everything else looks okay from an initial look at the matter
As for the gradle wrapper, the 1.20.x version of the mod does use latest gradle. I'm not modifying it for older versions of Minecraft unnecessarily as we don't plan on adding any more features to these older versions beyond simple bugfixes like this.
Also, are you certain that the bugfix should be done through Alchemistry and not over at AlchemyLib? Everything else looks okay from an initial look at the matter
In this case, the logic for detecting if an item is valid is specific to the block entity, so implementing it in Alchemistry makes sense as this logic wouldn't help with the other BEs.
Preliminary testing shows that this fix does work. I think the logic should be pushed to the other versions as well.
This is a fix for an issue I raised: https://github.com/SmashingMods/Alchemistry/issues/326
In short, the combiner recipe lock does not work with mekanism logistical pipes. It allows too many items to be inserted. Please see the issue for a breakdown.
For this fix: I have tested 2 scenarios: Can wool and triglycerine be made? Does the machine work without recipe lock?
Both scenarios pass my personal testing and we have begin to use my build locally on my server.
I also changed the build.gradle. The gradle appears to use java 17, but there was a command arg that appears to no longer exist, so I removed it as I could not launch the project with it.
I also added other mekanism components (commented out) to enable testing of the fix.
Unrelated: Locally, I had to create a gradle wrapper to set the gradle version because I am using gradle 8+ for other work. I recommend this file be commit so future users can build the source out-of-the-box.