search

Smertig / rcmp

C++17, multi-architecture cross-platform hooking library with clean API.
MIT License
74 stars 5 forks source link

feature request: add lib to xmake-repo #3

Open shevernitskiy opened 1 year ago

shevernitskiy commented 1 year ago

Hey! Thanks for a great hooking lib. You did exaclty what everybody thinking about!:) I suggest to add lib to xmake-repo. It will be very helpful for xmake users:) https://github.com/xmake-io/xmake-repo

ElCapor commented 7 months ago

I will give a try at adding it to xmake repo , even though i aint expert , i assume you'd just use the cmake backend in xmake

Smertig commented 6 months ago

Hey, @shevernitskiy. Thanks for your kind words! Apologize for the late response, I had a break from C++.

I did a few attempts on adding rcmp to the xmake-repo, but it seems there's no simple and direct way to write correct xmake.lua even in case of small CMake-based project that can be added as a subdirectory otherwise. Any help is highly appreciated, I'm leaving this issue as opened.

waruqi commented 6 months ago

https://github.com/xmake-io/xmake-repo/pull/3964

Smertig commented 6 months ago

@waruqi, thank you for your help! As I see from your PR to xmake-repo, you wrote some duplicated code, i.e. specified /include directory directly and added some defines for library version. I'm wondering if it's really needed? Can I somehow modify rcmp or CMakeLists.txt so xmake "recipe" becomes simpler?

waruqi commented 6 months ago

specified /include directory directly and added some defines for library version

  1. provide cmake install configuration to install headers/libs in CMakeLists.txt
  2. support static/shared for BUILD_SHARED_LIBS
  3. generate config.h file to save RCMP_VERSION_MAJOR/RCMP_VERSION_MINOR/RCMP_VERSION_PATCH or define them in rcmp code, otherwise when the user uses the library header files, they are undefined