search

Smeulf / userscripts

3 stars 1 forks source link

Press escape to close menu #1

Closed jesus2099 closed 6 years ago

jesus2099 commented 6 years ago

Hello @Smeulf, I think it’s quite natural to expect that pressing the Escape key will close the popup. I had to add an additional event propagation stopper (event.cancelBubble = true;) or pressing Escape would leave / unfocus / blur the last clicked input.

Smeulf commented 6 years ago

Looks good to me, thank you!

Btw, I created a dev branch I'll work on. In the future, can you please send the PR on this dev branch, for testing before I publish it on the master ? Thanks!