WFEugenioCelant
commented
2 years ago Hello,
wanted to update the issue since we've been debugging and testing it locally to check if there was any way to fix the issue. After a while I think we have a good understanding of the problem and where it resides. I am going to try and explain what we think is the problem and our "hacky" solution. Maybe an expect in the codebase can help us identify if the problem is indeed this or we are missing the mark.
We think the problem is that currently there is no management of blacklisted products for carousels and PageBuilder items in general. This is because we have not found any filters defined in etc/elasticsuite_search_request.xml specific for PageBuilder elements, but only generic one for category pages and search requests.
Currently we see that the PageBuilder carousel calls the standard category filters when setup to filter on a specific Category.
- module-elasticsuite-catalog: elasticsuite_search_request.xml
<request name="catalog_view_container"> <filters> <filter name="blacklistedProducts">Smile\ElasticsuiteVirtualCategory\Model\Product\Search\Request\Container\Filter\CategoryBlacklist</filter> </filters> </request>
This class bases its logic on an attribute $searchContext that is filled mainly with the category we are in. Since the PageBuilder is not a normal Category though, the $searchContext attribute is missing a vital information to remove blacklisted products.
Because of this in class Smile\ElasticsuiteVirtualCategory\Model\Rule\Condition\Product:getSearchQuery, this part of the function always returns null as $searchQuery since it does not have any Category to work off of:
if ($this->getAttribute() === 'category_ids') {
$searchQuery = $this->getCategorySearchQuery($excludedCategories, $virtualCategoryRoot);
}This is pretty much the whole explanation we have come up with. We have also developed a very basic (and probably bad, "hacky") solutionto the problem at hand. I will copy/paste it here but obviously it's not to be used and was just a proof of concept to check if assigning a value to the aformentioned category would sort any effects, which indeed does.
"Hacky" fix:
public function __construct(
\Magento\Rule\Model\Condition\Context $context,
\Magento\Backend\Helper\Data $backendData,
\Magento\Eav\Model\Config $config,
\Smile\ElasticsuiteCatalogRule\Model\Rule\Condition\Product\AttributeList $attributeList,
\Smile\ElasticsuiteCatalogRule\Model\Rule\Condition\Product\QueryBuilder $queryBuilder,
\Magento\Catalog\Model\ProductFactory $productFactory,
\Magento\Catalog\Api\ProductRepositoryInterface $productRepository,
\Magento\Catalog\Model\ResourceModel\Product $productResource,
\Magento\Eav\Model\ResourceModel\Entity\Attribute\Set\Collection $attrSetCollection,
\Magento\Framework\Locale\FormatInterface $localeFormat,
SpecialAttributesProvider $specialAttributesProvider,
\Smile\ElasticsuiteCore\Search\Request\Query\QueryFactory $queryFactory,
\Magento\Catalog\Model\CategoryRepository $categoryRepository,
\Smile\ElasticsuiteCore\Api\Search\ContextInterface $searchContext,
array $data = []
) {
parent::__construct(
$context,
$backendData,
$config,
$attributeList,
$queryBuilder,
$productFactory,
$productRepository,
$productResource,
$attrSetCollection,
$localeFormat,
$specialAttributesProvider,
$data
);
$this->queryFactory = $queryFactory;
$this->categoryRepository = $categoryRepository;
$this->searchContext = $searchContext;
}
....
public function getSearchQuery($excludedCategories = [], $virtualCategoryRoot = null): ?QueryInterface
{
$searchQuery = parent::getSearchQuery();
if ($this->getAttribute() === 'category_ids') {
$this->searchContext->setCurrentCategory($this->categoryRepository->get($this->getValueParsed()[0]));
$searchQuery = $this->getCategorySearchQuery($excludedCategories, $virtualCategoryRoot);
}
return $searchQuery;
}For a brief explaination: this just adds the $searchContext dependecy and sets the category by getting the current category from the value selected in the PageBuilder carousel.
Hoping this helps at least to better understand the problem at hand.
romainruaud
Description
By blacklisting a product in the category, it is still shown in FE carousels that retrieve the product using the category (did not test the other methods). Also, products blacklisted that are then removed from the category (via their own product pages in Backend) are still shown in FE carousels (always selected by category, didn't test other cases)
Preconditions
Magento Version : EE v.2.4.2-p1
ElasticSuite Version : tested on v.2.10.9 and v.2.10.9.1
Environment : both Developer and Production mode
Third party modules :
Steps to reproduce
php bin/magento indexer:reindexphp bin/magento indexer:reindexphp bin/magento indexer:reindexSorry for the (maybe too) redundant reindexes. Probably the
catalogsearch_fulltextwould have been enough.Expected result
Actual result
Other than what (I think) is already clear, I can say that the table
smile_virtualcategory_catalog_category_product_positionstill has a row for the added product, even after it has been removed from the category. Since the association is removed, shouldn't the row in the aformentioned table be removed too?Thanks very much in advance