Resolve Faker formatter earlier - Githubissues

Smile-SA / gdpr-dump

Utility that creates anonymized database dumps (MySQL only). Provides default config templates for Magento, Drupal and Shopware.

GNU General Public License v3.0

184 stars 47 forks source link

Resolve Faker formatter earlier #108

Closed staabm closed 9 months ago

staabm commented 9 months ago

PR Checklist

Please check if your pull request fulfills the following requirements:

[ ] The commit message follows our guidelines: https://github.com/Smile-SA/gdpr-dump/blob/main/CONTRIBUTING.md.
[x] Tests for the changes have been added (for bug fixes / features).
[ ] Docs have been added / updated (for bug fixes / features).

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

as discussed in https://github.com/Smile-SA/gdpr-dump/issues/106 with this PR we resolve Faker formatters earliser, so possible invalid formatters will be reported before the dump is started

Issue Number: #106

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

staabm commented 9 months ago

Thank you @guvra