Smile-SA / magento2-module-custom-entity-product-link

31 stars 12 forks source link

Admin product catalog full text filter displays error "Something went wrong with processing the default view and we have restored the filter to its original state." #24

Closed chrey closed 1 year ago

chrey commented 4 years ago

Version of the module installed on a Magento 2.3 with almost no developments : 1.1.1 The module is installed but not used with any entity created.

In the admin catalog product page : when using the full text filter with anything inside, error displayed :

Something went wrong with processing the default view and we have restored the filter to its original state.

Then you cannot use the page again unless you empty the table ui_bookmark for the admin user in the database

Error in the logs :

[2020-02-17 08:52:00] main.CRITICAL: Notice: Undefined variable: selects in /var/www/socomore-wm/releases/magento-project-community-edition-master-20200213161907/vendor/smile/module-custom-entity-product-link/Model/ResourceModel/Search/CustomCollection.php on line 110 {"exception":"[object] (Exception(code: 0): Notice: Undefined variable: selects in /var/www/socomore-wm/releases/magento-project-community-edition-master-20200213161907/vendor/smile/module-custom-entity-product-link/Model/ResourceModel/Search/CustomCollection.php on line 110 at /var/www/socomore-wm/releases/magento-project-community-edition-master-20200213161907/vendor/magento/framework/App/ErrorHandler.php:61)"} []

If you don't go inside the "if" the variable $selects is undefined.

When disabling this module, no more errors

wigman commented 4 years ago

Same here. Only occured after upgrading to Magento 2.3.5.

Disabling the module for now.

Amadeco commented 4 years ago

Good afternoon,

I have met this issue on my website too. I did a pull request (#26) a few minutes ago.

It solved my problem on Magento 2.4.1. In any case, this PHP condition is needed even in older version, in particular with error_reporting configured with E_ALL.

Ilan Parmentier