Checking custom SQL select before injection

Smile-SA / magento2-module-custom-entity-product-link

31 stars 12 forks source link

Closed Amadeco closed 2 years ago

Amadeco commented 4 years ago

Good afternoon,

Related to this issue #24, this pull requests check wether we need to inject Smile Custom Entity SQL with Magento one or not.

I am testing this issue on last version of Magento (2.4.1) and it solved my problem,

Sincerely yours,

Ilan Parmentier

yutv commented 2 years ago

Hello @romainruaud

Could we move forward with this PR? It fixes a real issue. As for the CI checks, it failed due to lack of Magento authentication keys: https://travis-ci.org/github/Smile-SA/magento2-module-custom-entity-product-link/jobs/743202243 and not related to the PR code.