search

Smile-SA / magento2-module-offer

Offer Module for Retailer Suite
6 stars 13 forks source link

Fix ES indexation #2

Closed pprmn closed 7 years ago

pprmn commented 7 years ago

Add product indexation on offer save Add ElasticSuite depency

romainruaud commented 7 years ago

The dependency to elasticsuite is wrong. See the email I received from packagist :

The smile/module-offer package of which you are a maintainer has failed to update due to invalid data contained in your composer.json. Please address this as soon as possible since the package stopped updating.

It is recommended that you use composer validate to check for errors when you change your composer.json.

Below is the full update log which should highlight errors as "Skipped branch ...":

[Composer\Repository\InvalidRepositoryException]: Some branches contained invalid data and were discarded, it is advised to review the log and fix any issues present in branches

Reading composer.json of smile/module-offer (master) Importing branch master (dev-master) Reading composer.json of smile/module-offer (1.0) Importing branch 1.0 (1.0.x-dev) Skipped branch 1.0, Invalid package information: require.elasticsuite/elasticsuite : invalid version constraint (Could not parse version constraint ^2.2.: Invalid version string "^2.2.")

Reading composer.json of smile/module-offer (1.1) Importing branch 1.1 (1.1.x-dev)

romainruaud commented 7 years ago

The elasticsuite/elasticsuite dependency should be smile/elasticsuite imho.