Layout / Template cleanup

Smile-SA / magento2-module-product-label

Module to handle custom labels with images on products

Open Software License 3.0

54 stars 36 forks source link

Layout / Template cleanup #12

Closed romainruaud closed 5 years ago

romainruaud commented 5 years ago

    <div class="productlabel-wrapper
        <?php if ($view == 'category'){ echo 'category';}?>
        <?php if ($view == 'product'){ echo 'product';}?>" id="smile-productlabels-wrapper">

=> Why not just echoing the $view or getCurrentView() ? ?

Seems like the foreach/switch part following could get simplified the same manner :

houdaElr commented 5 years ago

Done!