Module only checks custom attributes

Smile-SA / magento2-module-product-label

Module to handle custom labels with images on products

Open Software License 3.0

53 stars 34 forks source link

Module only checks custom attributes #28

Closed Quillatyam closed 9 months ago

Quillatyam commented 4 years ago

We ran into this issue when using the standard attribute 'visibility'.

The module only checks with $this->getProduct()->getCustomAttribute($attribute->getAttributeCode());, but that doesn't return selected options for 'standard attributes (which you would get with $this->getProduct()->getData($attribute->getAttributeCode());)

I made a (quick-and-dirty) patch working around this issue, I'll attach that to make it clearer what I mean. SMILE-MODULE-PRODUCT-LABEL1.1.1_CUSTOM_ATTRIBUTES.txt

cptX commented 1 year ago

Does this patch corrects the issue of not showing all the available attributes when setting the labels?