Smile-SA / magento2-module-product-label

Module to handle custom labels with images on products
Open Software License 3.0
54 stars 36 forks source link

M2.4.5-p1 - bug in admin grid making each record show the same data [Smile_ProductLabel 1.2.4] #57

Closed pcvvelzen closed 1 year ago

pcvvelzen commented 1 year ago

Current situation: This issue was encountered coming from a working situation with Magento 2.3.x and Smile_ProductLabel 1.1.x, issue found during upgrading to Magento to 2.4.5-p1 with latest version of Smile_ProductLabel 1.2.4 module.

This issue is related to a combination to a newer Magento and Smile_ProductLabel version, specifically 2.4.5-p1 and module v1.2.4 which are confirmed on a clean Magento codebase following these steps to reproduce:

The issue: After saving the second label the admin grid shows correct amount of results but only the info from the last created record at each row

image
pcvvelzen commented 1 year ago

Updated - managed to track down the issue with this module and Magento 2.4.5 p1 of which the changes are shared in this PR https://github.com/Smile-SA/magento2-module-product-label/pull/58

cemag44300 commented 1 year ago

@pcvvelzen Thank you for your report and your PR. I will check this today and do a new release