search

Smile-SA / magento2-module-product-label

Module to handle custom labels with images on products
Open Software License 3.0
54 stars 36 forks source link

selecting more than one storeview fails #62

Closed GK-Kedo closed 1 year ago

GK-Kedo commented 1 year ago

php 7.4.33 and magento 2.4.3-p3

When selecting more than one storeview in the backend while editing a product label, saving fails with:

TypeError: Return value of Smile\ProductLabel\Model\ProductLabel::getStores() must be of the type array, string returned in /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/vendor/smile/module-product-label/Model/ProductLabel.php:124
Stack trace:
#0 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/vendor/smile/module-product-label/Model/ResourceModel/ProductLabel.php(110): Smile\ProductLabel\Model\ProductLabel->getStores()
#1 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/vendor/smile/module-product-label/Model/ResourceModel/ProductLabel/Store/SaveHandler.php(20): Smile\ProductLabel\Model\ResourceModel\ProductLabel->saveStoreRelation()
#2 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/vendor/magento/framework/EntityManager/Operation/Update/UpdateExtensions.php(49): Smile\ProductLabel\Model\ResourceModel\ProductLabel\Store\SaveHandler->execute()
#3 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/vendor/magento/framework/EntityManager/Operation/Update.php(109): Magento\Framework\EntityManager\Operation\Update\UpdateExtensions->execute()
#4 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/vendor/magento/framework/EntityManager/EntityManager.php(106): Magento\Framework\EntityManager\Operation\Update->execute()
#5 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/vendor/smile/module-product-label/Model/ResourceModel/ProductLabel.php(82): Magento\Framework\EntityManager\EntityManager->save()
#6 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/vendor/smile/module-product-label/Model/Repository/Manager.php(151): Smile\ProductLabel\Model\ResourceModel\ProductLabel->save()
#7 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/vendor/smile/module-product-label/Model/Repository/ProductLabel.php(101): Smile\ProductLabel\Model\Repository\Manager->saveEntity()
#8 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/vendor/smile/module-product-label/Controller/Adminhtml/ProductLabel/Save.php(85): Smile\ProductLabel\Model\Repository\ProductLabel->save()
#9 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/vendor/magento/framework/Interception/Interceptor.php(58): Smile\ProductLabel\Controller\Adminhtml\ProductLabel\Save->execute()
#10 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/vendor/magento/framework/Interception/Interceptor.php(138): Smile\ProductLabel\Controller\Adminhtml\ProductLabel\Save\Interceptor->___callParent()
#11 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/vendor/magento/framework/Interception/Interceptor.php(153): Smile\ProductLabel\Controller\Adminhtml\ProductLabel\Save\Interceptor->Magento\Framework\Interception\{closure}()
#12 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/generated/code/Smile/ProductLabel/Controller/Adminhtml/ProductLabel/Save/Interceptor.php(23): Smile\ProductLabel\Controller\Adminhtml\ProductLabel\Save\Interceptor->___callPlugins()
#13 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/vendor/magento/framework/App/Action/Action.php(111): Smile\ProductLabel\Controller\Adminhtml\ProductLabel\Save\Interceptor->execute()
#14 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/vendor/magento/module-backend/App/AbstractAction.php(151): Magento\Framework\App\Action\Action->dispatch()
#15 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/vendor/magento/framework/Interception/Interceptor.php(58): Magento\Backend\App\AbstractAction->dispatch()
#16 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/vendor/magento/framework/Interception/Interceptor.php(138): Smile\ProductLabel\Controller\Adminhtml\ProductLabel\Save\Interceptor->___callParent()
#17 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/app/code/Lindbaum/InvalidSecurityFormKeyBugFix/App/Action/Plugin/AuthenticationOverride.php(140): Smile\ProductLabel\Controller\Adminhtml\ProductLabel\Save\Interceptor->Magento\Framework\Interception\{closure}()
#18 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/vendor/magento/framework/Interception/Interceptor.php(135): Lindbaum\InvalidSecurityFormKeyBugFix\App\Action\Plugin\AuthenticationOverride->aroundDispatch()
#19 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/vendor/magento/framework/Interception/Interceptor.php(153): Smile\ProductLabel\Controller\Adminhtml\ProductLabel\Save\Interceptor->Magento\Framework\Interception\{closure}()
#20 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/generated/code/Smile/ProductLabel/Controller/Adminhtml/ProductLabel/Save/Interceptor.php(32): Smile\ProductLabel\Controller\Adminhtml\ProductLabel\Save\Interceptor->___callPlugins()
#21 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/vendor/magento/framework/App/FrontController.php(245): Smile\ProductLabel\Controller\Adminhtml\ProductLabel\Save\Interceptor->dispatch()
#22 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/vendor/magento/framework/App/FrontController.php(212): Magento\Framework\App\FrontController->getActionResponse()
#23 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/vendor/magento/framework/App/FrontController.php(147): Magento\Framework\App\FrontController->processRequest()
#24 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/vendor/magento/framework/Interception/Interceptor.php(58): Magento\Framework\App\FrontController->dispatch()
#25 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/vendor/magento/framework/Interception/Interceptor.php(138): Magento\Framework\App\FrontController\Interceptor->___callParent()
#26 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/vendor/magento/framework/Interception/Interceptor.php(153): Magento\Framework\App\FrontController\Interceptor->Magento\Framework\Interception\{closure}()
#27 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/generated/code/Magento/Framework/App/FrontController/Interceptor.php(23): Magento\Framework\App\FrontController\Interceptor->___callPlugins()
#28 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/vendor/magento/framework/App/Http.php(116): Magento\Framework\App\FrontController\Interceptor->dispatch()
#29 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/vendor/magento/framework/Interception/Interceptor.php(58): Magento\Framework\App\Http->launch()
#30 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/vendor/magento/framework/Interception/Interceptor.php(138): Magento\Framework\App\Http\Interceptor->___callParent()
#31 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/vendor/magento/framework/Interception/Interceptor.php(153): Magento\Framework\App\Http\Interceptor->Magento\Framework\Interception\{closure}()
#32 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/generated/code/Magento/Framework/App/Http/Interceptor.php(23): Magento\Framework\App\Http\Interceptor->___callPlugins()
#33 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/vendor/magento/framework/App/Bootstrap.php(264): Magento\Framework\App\Http\Interceptor->launch()
#34 /var/www/vhosts/kedo.shop/httpdocs/magento2-stage/pub/index.php(29): Magento\Framework\App\Bootstrap->run()
#35 {main}