search

Smile-SA / magento2-module-retailer-offer

Retailer Offer Module for Retailer Suite
6 stars 24 forks source link

[VM-523] B: Prevent uncaught typeError when ElasticsuiteCatalog is no… #21

Closed Maikel-Koek closed 6 years ago

Maikel-Koek commented 6 years ago

…t enabled

Following error was thrown:


Fatal error: Uncaught TypeError: Argument 1 passed to Smile\RetailerOffer\Model\CollectionProcessor::applyStoreLimitation() must be an instance of Smile\ElasticsuiteCatalog\Model\ResourceModel\Product\Fulltext\Collection, instance of Magento\CatalogSearch\Model\ResourceModel\Fulltext\Collection\Interceptor given, called in /data/web/magento2/vendor/smile/module-retailer-offer/Plugin/LayerPlugin.php on line 46 and defined in /data/web/magento2/vendor/smile/module-retailer-offer/Model/CollectionProcessor.php on line 80```
romainruaud commented 6 years ago

Hello,

we will not merge this request, since RetailerOffer module is not meant to be used without ElasticsuiteCatalog : filtering of offers is done by the search engine (with a filter on the Elasticsearch query) when navigating.

So there is no point of using it withouth ElasticSuiteCatalog module since the filtering would not be able to work.

Regards

Maikel-Koek commented 6 years ago

@romainruaud OK, I get that. I just run in a lot of errors, since I don't need all of the suite's functionality, is there a way for me to just use the store locator (the retailer/seller entity)?

romainruaud commented 6 years ago

You should be able to install only the store locator module directly via composer : it should trigger also the installation of the seller and retailer module, which can be used stand-alone without elasticsuite.

Let me know