search

Smile-SA / smile-magento-elasticsearch

Magento ElasticSearch Implementation
151 stars 90 forks source link

FIX fallback to default Magento search if ES server is down (Issue #47) #88

Open mobilizer opened 7 years ago

mobilizer commented 7 years ago

Current implementation fails with an error if the Elasticsearch server is down, unavailable or catalog/search/engine configuration is set to "MySQL".

Call to undefined method Mage_Catalog_Model_Resource_Product_Collection::isSpellchecked()

There was already an issue covering this problem: https://github.com/Smile-SA/smile-magento-elasticsearch/issues/47

Cause: In default Magento catalogsearch result collection isSpellchecked() is not available.

kirmorozov commented 7 years ago

Yes, if you make elastic handle all the category and search traffic, there is no point to have worse search relevance. Just make sure elastic is running.

On Thu, Oct 27, 2016 at 9:31 PM, sam brown notifications@github.com wrote:

You are not suggesting we patch core magento files to fix this?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Smile-SA/smile-magento-elasticsearch/pull/88#issuecomment-256730370, or mute the thread https://github.com/notifications/unsubscribe-auth/AA9-iCVlqYsR37mgrl4DVdThECn3lKQLks5q4O30gaJpZM4Kiqgt .

Kirill Morozov

http://www.magentocommerce.com/certification/directory/dev/37578/

email kir.morozov@gmail.com kir.morozov@gmail.com US +1-424-27-27-050 RU +7-910-451-64-41 skype kir.morozov

mobilizer commented 7 years ago

At least when using ElasticSearch just for search and autocomplete... handling this error and doing a fallback should be good practice!? Is there any advantage in keeping this code line with an unhandled error?