Smile4ever / Neat-URL

Neat URL cleans URLs, removing parameters such as Google Analytics' utm parameters.
Other
631 stars 37 forks source link

Single filter source #187

Closed MarcelWaldvogel closed 4 years ago

MarcelWaldvogel commented 5 years ago

There used to be three instances of the filter lists, in README.md, in background.js, and in options.js. README.md had diverged from the rest. This makes sure that the list in README.md is now authoritative and the lists in background.js and options.js are always built from README.md

MarcelWaldvogel commented 5 years ago

I just noticed that there are two const PREFS in options.js, the second being at https://github.com/Smile4ever/Neat-URL/blob/master/options.js#L193. I presume the second one should be deleted?

Smile4ever commented 4 years ago

@MarcelWaldvogel I went for a solution that doesn't need the build script and instead uses fetch to get the new JSON file I introduced with version 5.0.0. That way I can keep developing locally.

Thank you for your time, though.