search

Smile4ever / Neat-URL

Neat URL cleans URLs, removing parameters such as Google Analytics' utm parameters.
Other
631 stars 37 forks source link

Deactivate notification sound #192

Closed kevinpapst closed 4 years ago

kevinpapst commented 5 years ago

Hi Geoffrey,

thanks for your wonderful Firefox extension! Unfortunately I am not only here to say Thank you but I also have a change request 🙄

Problem On MacOS Mojave (10.14.5) with Firefox 67.0 (64-Bit) and Neat-URL 4.1.5 each cleaned link results in a notification (which is fine) but also in an (annoying) system sound/beep. I can deactivate that behaviour for Firefox, but that setting applies to all Firefox notifications, which is actually not what I want.

One the one hand I am thankful that you made me even more aware about how many tracking links are used out there, one the other hand I find it difficult to bear that my computer is beeping all the time, because of all the cleaned links ;-)

Suggestion If I get it right, you use the Notifications API?! There is a silent option which you could try to add somewhere around here.

What do you think?

Smile4ever commented 4 years ago

Hi @kevinpapst

I am using the WebExtensions notifications API which doesn't have a silent option, unfortunately.

Documentation: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/notifications/NotificationOptions

So I'm sorry, but I can't change the default behaviour of the WebExtensions platform with some tweaking.

The only notification seems to be when the preferences get saved, so I don't understand that you get a notification with every cleaned link?

kevinpapst commented 4 years ago

Thanks for your answer @Smile4ever ! And sorry for missing that topic, I could have closed it earlier.... as I found out that it was actually the "Skip Redirect" extension which caused the beep and not Neat URL.

I got to research some javascript APIs that I didn't knew before, thats good. But I wasted your time with an invalid request: sorry for that!

Smile4ever commented 4 years ago

No problem.