search

Smile4ever / firefoxaddons

Extend the functionality of Firefox with cool addons
82 stars 20 forks source link

Neat URL: add Aliexpress tracking parameter #103

Closed dartraiden closed 6 years ago

dartraiden commented 6 years ago

spm (example: click on any item from the store)

In addition, it would be a good idea to add

aff_platform cpt sk aff_trace_key terminal_id

This tags added by partner sites that receive % of the purchase made by the link.

Smile4ever commented 6 years ago

I could add these:

spm@aliexpress.com aff_platform aff_trace_key terminal_id

I'm quite sure sk and cpt are used for different purposes as well and adding them might break other sites. But feel free to add them yourself to the preferences.

dartraiden commented 6 years ago

spm@aliexpress.com

Will this work with ru.aliexpress.com, de.aliexpress.com, etc?

Smile4ever commented 6 years ago

Good catch.

We need these:

spm@*.aliexpress.com
scm@*.aliexpress.com
aff_platform
aff_trace_key
terminal_id
Smile4ever commented 6 years ago

Added in 4.1.1.

crssi commented 6 years ago

Hmmm... just one question:

Does spm@*.aliexpress.com covers also domain aliexpress.com or only somesubdomain.aliexpress.com?

Should we have two rules for specofic parameter to cover them all like: spm@*.aliexpress.com spm@aliexpress.com

Smile4ever commented 6 years ago

Does spm@*.aliexpress.com covers also domain aliexpress.com or only somesubdomain.aliexpress.com?

It covers both. According to my tests, the *.aliexpress.com parameters work as intended: strip the parameter from the root domain and the subdomains.

Given the rule test@*.hugsmile.eu http://hugsmile.eu/nl/?test is rewritten to http://hugsmile.eu/nl

Should we have two rules for specofic parameter to cover them all like

No, if that is needed that would be a bug.