Smile4ever / firefoxaddons

Extend the functionality of Firefox with cool addons
84 stars 20 forks source link

[Neat URL] Amazon links not cleaned #31

Closed woctezuma closed 7 years ago

woctezuma commented 7 years ago

I don't know if it is intended, but Amazon links are not cleaned. I have noticed this behavior by testing the links shown on a similar addon page: https://addons.mozilla.org/fr/firefox/addon/link-cleaner/

screenshot

I don't care about skipping redirections, because I use another more general addon, which is not limited to Facebook, Steam and Reddit. However, I wonder whether there is a good reason not clean Amazon URLs. Maybe it interferes with the shopping process? I remember I tested Link Cleaner earlier this year and thought that the addon was too brutal and would break some websites.

Smile4ever commented 7 years ago

Hi. Thanks for opening an issue about https://www.amazon.com/AmazonBasics-Type-C-USB-Male-Cable/dp/B01GGKYQ02/ref=sr_1_1%3Fs=amazonbasics&srs=10112675011&ie=UTF8&qid=1489067885&sr=8-1&keywords=usb-c

I actually do a check before stripping all parameters off to prevent breaking certain URLs.

Could you provide me with the following information?

woctezuma commented 7 years ago

Neat URL 2.0.3

Parameters: the default ones plus 3 for Humble Bundle (hmb_campaign, hmb_source, hmb_medium).

utm_source, utm_medium, utm_term, utm_content, utm_campaign, utm_reader, utm_place, utm_userid, utm_cid, ga_source, ga_medium, ga_term, ga_content, ga_campaign, ga_place, yclid, _openstat, fb_action_ids, fb_action_types, fb_ref, fb_source, action_object_map, action_type_map, action_ref_map, gs_l, pd_rd_r@amazon.*, pd_rd_w@amazon.*, pd_rd_wg@amazon.*, _encoding@amazon.*, psc@amazon.*, ved@google.*, ei@google.*, sei@google.*, gws_rd@google.*, cvid@bing.com, form@bing.com, sk@bing.com, sp@bing.com, sc@bing.com, qs@bing.com, pq@bing.com, feature@youtube.com, gclid@youtube.com, kw@youtube.com, $/ref@amazon.*, hmb_campaign, hmb_source, hmb_medium

Firefox 55.0.3 (64 bits), Windows 10 Pro 64 v.1607 v.14393.1593 (bits)

woctezuma commented 7 years ago

When I click on your link, the addon works.

The link becomes this URL.

But if I click on the link shown on Link Cleaner homepage, it does not...

The only difference which I can spot between the two links is that the link which is cleaned has %3F and the one which does not has ? instead.

diff

Ghost8652 commented 7 years ago

Is there any update? I'm having this issue too.

Smile4ever commented 7 years ago

There will be an update this weekend which fixes these issues on Amazon product pages.

Smile4ever commented 7 years ago

Fixed by https://github.com/Smile4ever/firefoxaddons/commit/98dba5e93ba5b73dcacbfc4a2fb030d76c496d04 which is available in Neat URL 2.1.0.