Smile4ever / firefoxaddons

Extend the functionality of Firefox with cool addons
83 stars 20 forks source link

[Neat URL] Breaks Pocket / Firefox Accounts OAuth #86

Closed callahad closed 6 years ago

callahad commented 6 years ago

Using Firefox Nightly and Neat URL 3.2.0.

STR:

  1. (If applicable) Sign out of getpocket.com
  2. Navigate to a page and click the Pocket icon in the URL bar
  3. Click "Sign in with Firefox"

What should happen:

What actually happens:

Why this happens:

Neat URL appears to encode spaces as +, rather than a literal space or %20. For example:

Unmodified: https://accounts.firefox.com/oauth/signin?client_id=xxx&state=xxx&scope=profile:uid profile:email profile:display_name
w/Neat URL: https://accounts.firefox.com/oauth/signin?client_id=xxx&state=xxx&scope=profile:uid+profile:email+profile:display_name 

Note specifically scope=profile:uid profile:email profile:display_name vs scope=profile:uid+profile:email+profile:display_name

Smile4ever commented 6 years ago

Have you tried the latest Neat URL git code?

callahad commented 6 years ago

Ah, yep, this was resolved by 0e5a92662ae3e159740337ea23adbec0cac97c42