Smile4ever / firefoxaddons

Extend the functionality of Firefox with cool addons
82 stars 20 forks source link

Translate Now - addon toolbar button iframe/frame selections don't work #90

Closed drmusti closed 6 years ago

drmusti commented 6 years ago

hi dear author your addon toolbar button iframe texts and frame text false. dont work. :( please find solution. thanks.

Smile4ever commented 6 years ago

On which site do you experience this issue?

drmusti commented 6 years ago

FF v57 all iframe , frames. all sites. context menu no proplem in iframe selected text. but addon toolbar button iframe texts and frame text false. dont work. :(

https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_iframe

http://www.opec.org/opec_web/en/2758.htm try "Please sign in to send your request:".... with toolbar button....

frames. all sites.toolbar button. false..

thanks.

Smile4ever commented 6 years ago

The iframe handling was indeed not working anymore, will be fixed in the next release. That solves the w3schools selection.

On opec.org: iframe is HTTPS, page is HTTP. Unfortunately that does not work due to technical limitations so there is nothing that can be done here.

Smile4ever commented 6 years ago

This has been fixed in Translate Now 3.1.5.

drmusti commented 6 years ago

please exaple a url for this solution for test. thanks

Smile4ever commented 6 years ago

You can use https://www.w3schools.com/html/html_iframe.asp Select any text in the iframe and click on the toolbar button.

For the remaining cases that don't work, I'm afraid nothing can be done except for teaching users to use the context menus.

drmusti commented 6 years ago

yes working in frame button action . you great coder. super programmer. bravo.

drmusti commented 6 years ago

http://urlmidi.com/test dear dont work some iframes. examle urlmidi http://urlmidi.com/test please check. Sincerely.

Smile4ever commented 6 years ago

This is due to mixed HTTP / HTTPS usage and cannot be fixed (sadly).