SmileYzn / MatchBot

Counter-Strike 1.6 Match Plugin for ReHLDS and ReGameDLL_CS
GNU General Public License v3.0
28 stars 14 forks source link

2nd Half warmup player score bug.... #110

Closed Escap3d closed 7 months ago

Escap3d commented 7 months ago

Can not b default player score in 1st half then after !start the 2nd half player score its show on 2nd half warmup kills and death added on 2nd half not show 1st half score.. sorry my bad english hope u understand :(

SmileYzn commented 7 months ago
// Store team scores in scoreboard
//
// 0 Disabled
// 1 Enabled
//
// Default "1"
mb_scoreboard_team "1"

// Store player scores in scoreboard
//
// 0 Disabled
// 1 Enabled
//
// Default "1"
mb_scoreboard_player "1"
Escap3d commented 7 months ago

// Store team scores in scoreboard // // 0 Disabled // 1 Enabled // // Default "1" mb_scoreboard_team "1"

// Store player scores in scoreboard // // 0 Disabled // 1 Enabled // // Default "1" mb_scoreboard_player "1" C1FD65C6-5AFE-409F-B806-EC8EAEBBE92C

I am saying that player score can not original score in first half aftar warmup some round playing then start the 2nd half per player score is showing is warmup score add in 2nd half..

i am saying warmup score not add player score in warmup system after 2nd half

SmileYzn commented 7 months ago

The real logic of scoreboard is:

  1. Reset player and team scores at match start
  2. Store players and team scores in first half
  3. Maintain player and team scores in halftime and when second half starts
  4. Maintain player and team scores at overtime and consecutives halftimes of overtime
  5. Maintain player and team scores at match end

Basically, is store player and team scores at whole match in scoreboard.

What exactly is wrong here? If you mean that halftime frags and scores is counting in scoreboard? Even after start the second half?

You can make a video to demonstrate it

SmileYzn commented 7 months ago

Or you mean at halftime, you used !start command to start second half and messed up scores??

Escap3d commented 7 months ago

Or you mean at halftime, you used !start command to start second half and messed up scores??

Yes only player score mixed up.. then start the cmd then player score is 1st hlf not minus score

SmileYzn commented 7 months ago

I will review it

Escap3d commented 7 months ago

In the second half, the player's score is getting reset, which should not happen. What I meant to say was that when halftime occurs, the warm-up time starts until the admin initiates the match. When the admin starts the match, the warm-up kills and deaths should not be added. Only the score from the first half should continue into the second half until the end of the match without any advantage or disadvantage of starting from zero. We are conducting a tournament, and we are informing you about the issues we are facing. Please don't mind. @SmileYzn

SmileYzn commented 7 months ago

Try to test here for linux: https://github.com/SmileYzn/MatchBot/actions/runs/7650029001 Or here for windows: https://github.com/SmileYzn/MatchBot/actions/runs/7650029002

Escap3d commented 7 months ago

Try to test here for linux: https://github.com/SmileYzn/MatchBot/actions/runs/7650029001 Or here for windows: https://github.com/SmileYzn/MatchBot/actions/runs/7650029002

Its that fix to continue the player score in 2nd half not halftime..

SmileYzn commented 7 months ago

You need to store player score in halftime too? I did not understand

Escap3d commented 7 months ago

I understand now. You are saying that the player's score should not be reset to zero in the second half. During halftime, the kills and deaths that occur during warm-up should be added, and when the second half starts, the kills and deaths in the second half should be added as well. The score from halftime should not be deducted, and the score from the first half should continue into the second half until the end of the overtime. I apologize for the confusion. I have reset the score, but I will make sure to continue the first half's score into the second half for the remaining duration of the overtime.

SmileYzn commented 7 months ago

Yes, it shoud be like

First Half: Nothing to do Half Time: Normal scores, is not live Second Half: At first round of Second half, scores are set to last scores of first half Half Time: Normal scores, is not live (If is overtime) Overtime: Reset scores to last scores of second half

I guess that is solved for now?

drakin003 commented 7 months ago

Yes, it shoud be like

First Half: Nothing to do Half Time: Normal scores, is not live Second Half: At first round of Second half, scores are set to last scores of first half Half Time: Normal scores, is not live (If is overtime) Overtime: Reset scores to last scores of second half

I guess that is solved for now?

his trying to say this same thing

SmileYzn commented 7 months ago

I guess that is fixed?

Closing it